Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 701633002: Chromecast: adds handler to log metrics from external processes. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
4 years, 5 months ago
Reviewers:
lcwu1, Will Harris
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Chromecast: adds handler to log metrics from external processes. R=lcwu@chromium.org BUG=336640 Committed: https://crrev.com/dcfbc68c6b74bd50e25098a6cf81b16209d4dce6 Cr-Commit-Position: refs/heads/master@{#302916}

Patch Set 1 #

Patch Set 2 : style nit #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+303 lines, -5 lines) Patch
M chromecast/browser/metrics/cast_metrics_service_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 3 chunks +14 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_stability_metrics_provider.h View 5 chunks +14 lines, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_stability_metrics_provider.cc View 3 chunks +20 lines, -1 line 1 comment Download
A chromecast/browser/metrics/external_metrics.h View 1 chunk +72 lines, -0 lines 0 comments Download
A chromecast/browser/metrics/external_metrics.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +12 lines, -0 lines 0 comments Download
M chromecast/common/pref_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromecast/common/pref_names.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
gunsch
6 years, 1 month ago (2014-11-03 22:19:56 UTC) #1
lcwu1
lgtm
6 years, 1 month ago (2014-11-05 22:52:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701633002/20001
6 years, 1 month ago (2014-11-05 22:56:08 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-06 00:21:50 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dcfbc68c6b74bd50e25098a6cf81b16209d4dce6 Cr-Commit-Position: refs/heads/master@{#302916}
6 years, 1 month ago (2014-11-06 00:22:54 UTC) #6
Will Harris
https://codereview.chromium.org/701633002/diff/20001/chromecast/browser/metrics/cast_stability_metrics_provider.cc File chromecast/browser/metrics/cast_stability_metrics_provider.cc (right): https://codereview.chromium.org/701633002/diff/20001/chromecast/browser/metrics/cast_stability_metrics_provider.cc#newcode104 chromecast/browser/metrics/cast_stability_metrics_provider.cc:104: IncrementPrefValue(prefs::kStabilityOtherUserCrashCount); I don't think these prefs are being registered ...
4 years, 5 months ago (2016-07-07 20:26:49 UTC) #8
Will Harris
4 years, 5 months ago (2016-07-07 20:26:50 UTC) #9
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698