Chromecast: adds handler to log metrics from external processes.

chromecast/browser/metrics/cast_stability_metrics_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/metrics/cast_stability_metrics_provider.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/metrics/sparse_histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "chromecast/browser/metrics/cast_metrics_service_client.h"
 #include "chromecast/common/chromecast_config.h"
 #include "chromecast/common/pref_names.h"
+#include "components/metrics/metrics_service.h"
 #include "components/metrics/proto/system_profile.pb.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/navigation_controller.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/user_metrics.h"
 
 namespace chromecast {
 namespace metrics {
@@ skipping 15 matching lines @@
 
 }  // namespace
 
 // static
 void CastStabilityMetricsProvider::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterIntegerPref(prefs::kStabilityRendererCrashCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilityRendererHangCount, 0);
   registry->RegisterIntegerPref(prefs::kStabilityChildProcessCrashCount, 0);
 }
 
-CastStabilityMetricsProvider::CastStabilityMetricsProvider() {
+CastStabilityMetricsProvider::CastStabilityMetricsProvider(
+    ::metrics::MetricsService* metrics_service)
+    : metrics_service_(metrics_service) {
   BrowserChildProcessObserver::Add(this);
 }
 
 CastStabilityMetricsProvider::~CastStabilityMetricsProvider() {
   BrowserChildProcessObserver::Remove(this);
 }
 
 void CastStabilityMetricsProvider::OnRecordingEnabled() {
   registrar_.Add(this,
                  content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
@@ skipping 25 matching lines @@
     pref->SetInteger(prefs::kStabilityRendererCrashCount, 0);
   }
 
   count = pref->GetInteger(prefs::kStabilityRendererHangCount);
   if (count) {
     stability_proto->set_renderer_hang_count(count);
     pref->SetInteger(prefs::kStabilityRendererHangCount, 0);
   }
 }
 
+void CastStabilityMetricsProvider::LogExternalCrash(
+    const std::string& crash_type) {
+  if (crash_type == "user")
+    IncrementPrefValue(prefs::kStabilityOtherUserCrashCount);

[Will Harris, 2016/07/07 20:26:49]

I don't think these prefs are being registered anywhere, are they?

+  else if (crash_type == "kernel")
+    IncrementPrefValue(prefs::kStabilityKernelCrashCount);
+  else if (crash_type == "uncleanshutdown")
+    IncrementPrefValue(prefs::kStabilitySystemUncleanShutdownCount);
+  else
+    NOTREACHED() << "Unexpected crash type " << crash_type;
+
+  // Wake up metrics logs sending if necessary now that new
+  // log data is available.
+  metrics_service_->OnApplicationNotIdle();
+}
+
 void CastStabilityMetricsProvider::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   switch (type) {
     case content::NOTIFICATION_RENDERER_PROCESS_CLOSED: {
       content::RenderProcessHost::RendererClosedDetails* process_details =
           content::Details<content::RenderProcessHost::RendererClosedDetails>(
               details).ptr();
       content::RenderProcessHost* host =
@@ skipping 35 matching lines @@
     UMA_HISTOGRAM_PERCENTAGE("BrowserRenderProcessHost.DisconnectedAlive", 1);
   }
 }
 
 void CastStabilityMetricsProvider::LogRendererHang() {
   IncrementPrefValue(prefs::kStabilityRendererHangCount);
 }
 
 }  // namespace metrics
 }  // namespace chromecast