Source/core/rendering/RenderBox.h - Issue 70163005: Fix clientLeft value for RTL direction, while the element have vertical scrollbar in left side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.h

Issue 70163005: Fix clientLeft value for RTL direction, while the element have vertical scrollbar in left side. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/scrollbars/rtl/div-horizontal-with-vertical-scrollbar-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBox.h

diff --git a/Source/core/rendering/RenderBox.h b/Source/core/rendering/RenderBox.h

index 0ec1ff8d69c29d47b4638071d5ab06fe1e0639ab..e4bc4f0c9110cc9c22986834eb3a5024f0e374df 100644

--- a/Source/core/rendering/RenderBox.h

+++ b/Source/core/rendering/RenderBox.h

@@ -251,7 +251,7 @@ public:

// More IE extensions. clientWidth and clientHeight represent the interior of an object

// excluding border and scrollbar. clientLeft/Top are just the borderLeftWidth and borderTopWidth.

- LayoutUnit clientLeft() const { return borderLeft(); }

+ LayoutUnit clientLeft() const { return borderLeft() + (style()->shouldPlaceBlockDirectionScrollbarOnLogicalLeft() ? verticalScrollbarWidth() : 0); }

LayoutUnit clientTop() const { return borderTop(); }

LayoutUnit clientWidth() const;

LayoutUnit clientHeight() const;