Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: Source/core/rendering/RenderBox.h

Issue 70163005: Fix clientLeft value for RTL direction, while the element have vertical scrollbar in left side. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 233 matching lines...) Expand 10 before | Expand all | Expand 10 after
244 virtual LayoutUnit offsetHeight() const OVERRIDE { return height(); } 244 virtual LayoutUnit offsetHeight() const OVERRIDE { return height(); }
245 245
246 virtual int pixelSnappedOffsetWidth() const OVERRIDE FINAL; 246 virtual int pixelSnappedOffsetWidth() const OVERRIDE FINAL;
247 virtual int pixelSnappedOffsetHeight() const OVERRIDE FINAL; 247 virtual int pixelSnappedOffsetHeight() const OVERRIDE FINAL;
248 248
249 bool canDetermineWidthWithoutLayout() const; 249 bool canDetermineWidthWithoutLayout() const;
250 LayoutUnit fixedOffsetWidth() const; 250 LayoutUnit fixedOffsetWidth() const;
251 251
252 // More IE extensions. clientWidth and clientHeight represent the interior of an object 252 // More IE extensions. clientWidth and clientHeight represent the interior of an object
253 // excluding border and scrollbar. clientLeft/Top are just the borderLeftWi dth and borderTopWidth. 253 // excluding border and scrollbar. clientLeft/Top are just the borderLeftWi dth and borderTopWidth.
254 LayoutUnit clientLeft() const { return borderLeft(); } 254 LayoutUnit clientLeft() const { return borderLeft() + (style()->shouldPlaceB lockDirectionScrollbarOnLogicalLeft() ? verticalScrollbarWidth() : 0); }
255 LayoutUnit clientTop() const { return borderTop(); } 255 LayoutUnit clientTop() const { return borderTop(); }
256 LayoutUnit clientWidth() const; 256 LayoutUnit clientWidth() const;
257 LayoutUnit clientHeight() const; 257 LayoutUnit clientHeight() const;
258 LayoutUnit clientLogicalWidth() const { return style()->isHorizontalWritingM ode() ? clientWidth() : clientHeight(); } 258 LayoutUnit clientLogicalWidth() const { return style()->isHorizontalWritingM ode() ? clientWidth() : clientHeight(); }
259 LayoutUnit clientLogicalHeight() const { return style()->isHorizontalWriting Mode() ? clientHeight() : clientWidth(); } 259 LayoutUnit clientLogicalHeight() const { return style()->isHorizontalWriting Mode() ? clientHeight() : clientWidth(); }
260 LayoutUnit clientLogicalBottom() const { return borderBefore() + clientLogic alHeight(); } 260 LayoutUnit clientLogicalBottom() const { return borderBefore() + clientLogic alHeight(); }
261 LayoutRect clientBoxRect() const { return LayoutRect(clientLeft(), clientTop (), clientWidth(), clientHeight()); } 261 LayoutRect clientBoxRect() const { return LayoutRect(clientLeft(), clientTop (), clientWidth(), clientHeight()); }
262 262
263 int pixelSnappedClientWidth() const; 263 int pixelSnappedClientWidth() const;
264 int pixelSnappedClientHeight() const; 264 int pixelSnappedClientHeight() const;
(...skipping 509 matching lines...) Expand 10 before | Expand all | Expand 10 after
774 if (UNLIKELY(inlineBoxWrapper() != 0)) 774 if (UNLIKELY(inlineBoxWrapper() != 0))
775 deleteLineBoxWrapper(); 775 deleteLineBoxWrapper();
776 } 776 }
777 777
778 ensureRareData().m_inlineBoxWrapper = boxWrapper; 778 ensureRareData().m_inlineBoxWrapper = boxWrapper;
779 } 779 }
780 780
781 } // namespace WebCore 781 } // namespace WebCore
782 782
783 #endif // RenderBox_h 783 #endif // RenderBox_h
OLDNEW
« no previous file with comments | « LayoutTests/scrollbars/rtl/div-horizontal-with-vertical-scrollbar-expected.txt ('k') | Source/core/rendering/RenderBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698