Issue 70163002: Add explicit Isolate parameter to External::New

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 70163002: Add explicit Isolate parameter to External::New (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne, svenpanne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Add explicit Isolate parameter to External::New We can't deprecate the non-Isolate version yet but soon will. R=svenpanne@chromium.org, svenpanne@google.com BUG=266838 Committed: https://code.google.com/p/v8/source/detail?r=17638

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+59 lines, -50 lines)			Patch
M	include/v8.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	samples/process.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+11 lines, -6 lines	0 comments	Download
M	test/cctest/test-accessors.cc	View	1 chunk	+9 lines, -12 lines	0 comments	Download
M	test/cctest/test-api.cc	View	10 chunks	+26 lines, -25 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	4 chunks	+8 lines, -4 lines	0 comments	Download
M	test/cctest/test-decls.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

jochen (gone - plz use gerrit)

7 years, 1 month ago (2013-11-12 11:45:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17638 (presubmit successful).