Add explicit Isolate parameter to External::New

test/cctest/test-cpu-profiler.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 700 matching lines @@
 TEST(NativeAccessorUninitializedIC) {
   LocalContext env;
   v8::HandleScope scope(env->GetIsolate());
 
 
   v8::Local<v8::FunctionTemplate> func_template = v8::FunctionTemplate::New();
   v8::Local<v8::ObjectTemplate> instance_template =
       func_template->InstanceTemplate();
 
   TestApiCallbacks accessors(100);
-  v8::Local<v8::External> data = v8::External::New(&accessors);
+  v8::Local<v8::External> data =
+      v8::External::New(env->GetIsolate(), &accessors);
   instance_template->SetAccessor(
       v8::String::New("foo"), &TestApiCallbacks::Getter,
       &TestApiCallbacks::Setter, data);
   v8::Local<v8::Function> func = func_template->GetFunction();
   v8::Local<v8::Object> instance = func->NewInstance();
   env->Global()->Set(v8::String::New("instance"), instance);
 
   v8::Script::Compile(v8::String::New(native_accessor_test_source))->Run();
   v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(
       env->Global()->Get(v8::String::New("start")));
@@ skipping 19 matching lines @@
 TEST(NativeAccessorMonomorphicIC) {
   LocalContext env;
   v8::HandleScope scope(env->GetIsolate());
 
 
   v8::Local<v8::FunctionTemplate> func_template = v8::FunctionTemplate::New();
   v8::Local<v8::ObjectTemplate> instance_template =
       func_template->InstanceTemplate();
 
   TestApiCallbacks accessors(1);
-  v8::Local<v8::External> data = v8::External::New(&accessors);
+  v8::Local<v8::External> data =
+      v8::External::New(env->GetIsolate(), &accessors);
   instance_template->SetAccessor(
       v8::String::New("foo"), &TestApiCallbacks::Getter,
       &TestApiCallbacks::Setter, data);
   v8::Local<v8::Function> func = func_template->GetFunction();
   v8::Local<v8::Object> instance = func->NewInstance();
   env->Global()->Set(v8::String::New("instance"), instance);
 
   v8::Script::Compile(v8::String::New(native_accessor_test_source))->Run();
   v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(
       env->Global()->Get(v8::String::New("start")));
@@ skipping 28 matching lines @@
 "    instance.fooMethod();\n"
 "  }\n"
 "}\n";
 
 
 TEST(NativeMethodUninitializedIC) {
   LocalContext env;
   v8::HandleScope scope(env->GetIsolate());
 
   TestApiCallbacks callbacks(100);
-  v8::Local<v8::External> data = v8::External::New(&callbacks);
+  v8::Local<v8::External> data =
+      v8::External::New(env->GetIsolate(), &callbacks);
 
   v8::Local<v8::FunctionTemplate> func_template = v8::FunctionTemplate::New();
   func_template->SetClassName(v8::String::New("Test_InstanceCostructor"));
   v8::Local<v8::ObjectTemplate> proto_template =
       func_template->PrototypeTemplate();
   v8::Local<v8::Signature> signature = v8::Signature::New(func_template);
   proto_template->Set(v8::String::New("fooMethod"), v8::FunctionTemplate::New(
       &TestApiCallbacks::Callback, data, signature, 0));
 
   v8::Local<v8::Function> func = func_template->GetFunction();
@@ skipping 16 matching lines @@
   v8::CpuProfiler* cpu_profiler = env->GetIsolate()->GetCpuProfiler();
   cpu_profiler->DeleteAllCpuProfiles();
 }
 
 
 TEST(NativeMethodMonomorphicIC) {
   LocalContext env;
   v8::HandleScope scope(env->GetIsolate());
 
   TestApiCallbacks callbacks(1);
-  v8::Local<v8::External> data = v8::External::New(&callbacks);
+  v8::Local<v8::External> data =
+      v8::External::New(env->GetIsolate(), &callbacks);
 
   v8::Local<v8::FunctionTemplate> func_template = v8::FunctionTemplate::New();
   func_template->SetClassName(v8::String::New("Test_InstanceCostructor"));
   v8::Local<v8::ObjectTemplate> proto_template =
       func_template->PrototypeTemplate();
   v8::Local<v8::Signature> signature = v8::Signature::New(func_template);
   proto_template->Set(v8::String::New("fooMethod"), v8::FunctionTemplate::New(
       &TestApiCallbacks::Callback, data, signature, 0));
 
   v8::Local<v8::Function> func = func_template->GetFunction();
@@ skipping 575 matching lines @@
       ProfileGenerator::kAnonymousFunctionName);
   CheckFunctionDetails(script, ProfileGenerator::kAnonymousFunctionName,
       "script_b", script_b->GetId(), 1, 1);
   const v8::CpuProfileNode* baz = GetChild(script, "baz");
   CheckFunctionDetails(baz, "baz", "script_b", script_b->GetId(), 3, 16);
   const v8::CpuProfileNode* foo = GetChild(baz, "foo");
   CheckFunctionDetails(foo, "foo", "script_a", script_a->GetId(), 2, 1);
   const v8::CpuProfileNode* bar = GetChild(foo, "bar");
   CheckFunctionDetails(bar, "bar", "script_a", script_a->GetId(), 3, 14);
 }