Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 701473002: Make generic algorithm less generic. (Closed)

Created:
6 years, 1 month ago by Michael Starzinger
Modified:
6 years, 1 month ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make generic algorithm less generic. R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25064

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Jaro. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -223 lines) Patch
M src/compiler/generic-algorithm.h View 1 4 chunks +10 lines, -23 lines 0 comments Download
M src/compiler/graph-reducer.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/compiler/graph-replay.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-replay.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 6 chunks +4 lines, -6 lines 0 comments Download
M src/compiler/js-context-specialization.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/js-inlining.cc View 4 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/scheduler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/compiler/typer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +1 line, -32 lines 0 comments Download
M src/compiler/verifier.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-node-algorithm.cc View 3 chunks +2 lines, -140 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Starzinger
The generic algorithm has been very generic these days. This generic change generically un-generifies the ...
6 years, 1 month ago (2014-11-03 09:43:55 UTC) #1
Jarin
lgtm. Nice! https://codereview.chromium.org/701473002/diff/1/src/compiler/generic-algorithm.h File src/compiler/generic-algorithm.h (right): https://codereview.chromium.org/701473002/diff/1/src/compiler/generic-algorithm.h#newcode51 src/compiler/generic-algorithm.h:51: SetVisited(&visited, id, true); How about removing the ...
6 years, 1 month ago (2014-11-03 10:06:44 UTC) #2
Michael Starzinger
Thanks. Addressed. Landing. https://codereview.chromium.org/701473002/diff/1/src/compiler/generic-algorithm.h File src/compiler/generic-algorithm.h (right): https://codereview.chromium.org/701473002/diff/1/src/compiler/generic-algorithm.h#newcode51 src/compiler/generic-algorithm.h:51: SetVisited(&visited, id, true); On 2014/11/03 10:06:43, ...
6 years, 1 month ago (2014-11-03 10:23:06 UTC) #3
Michael Starzinger
6 years, 1 month ago (2014-11-03 10:23:57 UTC) #4
Michael Starzinger
6 years, 1 month ago (2014-11-03 10:30:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25064 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698