Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: src/compiler/graph-visualizer.cc

Issue 701473002: Make generic algorithm less generic. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments by Jaro. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/graph-replay.cc ('k') | src/compiler/js-context-specialization.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/graph-visualizer.cc
diff --git a/src/compiler/graph-visualizer.cc b/src/compiler/graph-visualizer.cc
index 19f533b1c0ff33c7813d7b8e653624cec7fc0a11..e0cf8f05e455e5051e1576955d74c80b96605595 100644
--- a/src/compiler/graph-visualizer.cc
+++ b/src/compiler/graph-visualizer.cc
@@ -66,7 +66,7 @@ class JSONGraphNodeWriter : public NullNodeVisitor {
void Print() { const_cast<Graph*>(graph_)->VisitNodeInputsFromEnd(this); }
- GenericGraphVisit::Control Pre(Node* node);
+ void Pre(Node* node);
private:
std::ostream& os_;
@@ -77,7 +77,7 @@ class JSONGraphNodeWriter : public NullNodeVisitor {
};
-GenericGraphVisit::Control JSONGraphNodeWriter::Pre(Node* node) {
+void JSONGraphNodeWriter::Pre(Node* node) {
if (first_node_) {
first_node_ = false;
} else {
@@ -105,7 +105,6 @@ GenericGraphVisit::Control JSONGraphNodeWriter::Pre(Node* node) {
os_ << ",\"control\":" << (NodeProperties::IsControl(node) ? "true"
: "false");
os_ << "}";
- return GenericGraphVisit::CONTINUE;
}
@@ -172,7 +171,7 @@ class GraphVisualizer : public NullNodeVisitor {
void Print();
- GenericGraphVisit::Control Pre(Node* node);
+ void Pre(Node* node);
private:
void AnnotateNode(Node* node);
@@ -202,7 +201,7 @@ static Node* GetControlCluster(Node* node) {
}
-GenericGraphVisit::Control GraphVisualizer::Pre(Node* node) {
+void GraphVisualizer::Pre(Node* node) {
if (all_nodes_.count(node) == 0) {
Node* control_cluster = GetControlCluster(node);
if (control_cluster != NULL) {
@@ -215,7 +214,6 @@ GenericGraphVisit::Control GraphVisualizer::Pre(Node* node) {
all_nodes_.insert(node);
if (use_to_def_) white_nodes_.insert(node);
}
- return GenericGraphVisit::CONTINUE;
}
« no previous file with comments | « src/compiler/graph-replay.cc ('k') | src/compiler/js-context-specialization.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698