Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 701463004: Removing instrumentations for task URLFetcherCore::OnCompletedURLRequest (Closed)

Created:
6 years, 1 month ago by vadimt
Modified:
6 years, 1 month ago
Reviewers:
CC:
chromium-reviews, grt+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, Takashi Toyoshima, dconnelly, Peter Kasting, Nicolas Zea, Yoyo Zhou, mmenke, dcheng, mattm, James Hawkins, Roger Tawa OOO till Jul 10th
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing instrumentations for task URLFetcherCore::OnCompletedURLRequest The jank almost disappeared, either because it was fixed, or its numbers were absorbed by other instrumentations. At the current moment in Win, instrumentation for OAuth2AccessTokenFetcherImpl::OnURLFetchComplete shown 1.65 118ms jph, and remaining own jankiness of URLFetcherCore::OnCompletedURLRequest is 2.87. BUG=422577 TBR=toyoshim@chromium.org, dconnelly@chromium.org, pkasting@chromium.org, zea@chromium.org, yoz@chromium.org, mmenke@chromium.org, dcheng@chromium.org, mattm@chromium.org, jhawkins@chromium.org, rogerta@chromium.org Committed: https://crrev.com/c17c4cf24972a763a82230383fd40bd29620bab3 Cr-Commit-Position: refs/heads/master@{#302620}

Patch Set 1 #

Patch Set 2 : One more removal. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -114 lines) Patch
M chrome/browser/intranet_redirect_detector.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_service.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/captive_portal/captive_portal_detector.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/invalidation/gcm_network_channel.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/translate/core/browser/translate_language_list.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M components/translate/core/browser/translate_script.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/translate/core/browser/translate_url_fetcher.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/browser/updater/extension_downloader.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M sync/internal_api/http_bridge.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/701463004/20001
6 years, 1 month ago (2014-11-04 15:46:04 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 16:53:26 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 16:54:03 UTC) #4
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c17c4cf24972a763a82230383fd40bd29620bab3
Cr-Commit-Position: refs/heads/master@{#302620}

Powered by Google App Engine
This is Rietveld 408576698