Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Unified Diff: components/translate/core/browser/translate_language_list.cc

Issue 701463004: Removing instrumentations for task URLFetcherCore::OnCompletedURLRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: One more removal. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/translate_language_list.cc
diff --git a/components/translate/core/browser/translate_language_list.cc b/components/translate/core/browser/translate_language_list.cc
index 0edd96c1eb75eaae1b1fe7ca307aff2fcc4db951..d791c0171948c719d8e8a89797455d9053f38801 100644
--- a/components/translate/core/browser/translate_language_list.cc
+++ b/components/translate/core/browser/translate_language_list.cc
@@ -10,7 +10,6 @@
#include "base/json/json_reader.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
#include "base/values.h"
@@ -229,11 +228,6 @@ void TranslateLanguageList::OnLanguageListFetchComplete(
int id,
bool success,
const std::string& data) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "422577 TranslateLanguageList::OnLanguageListFetchComplete"));
-
if (!success) {
// Since it fails just now, omit to schedule resource requests if
// ResourceRequestAllowedNotifier think it's ready. Otherwise, a callback
@@ -256,22 +250,12 @@ void TranslateLanguageList::OnLanguageListFetchComplete(
}
void TranslateLanguageList::NotifyEvent(int line, const std::string& message) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "422577 TranslateLanguageList::NotifyEvent"));
-
TranslateEventDetails details(__FILE__, line, message);
callback_list_.Notify(details);
}
void TranslateLanguageList::SetSupportedLanguages(
const std::string& language_list) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "422577 TranslateLanguageList::SetSupportedLanguages 1"));
-
// The format is:
// sl({
// "sl": {"XX": "LanguageName", ...},
@@ -295,19 +279,9 @@ void TranslateLanguageList::SetSupportedLanguages(
kLanguageListCallbackNameLength,
language_list.size() - kLanguageListCallbackNameLength - 1);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "422577 TranslateLanguageList::SetSupportedLanguages 2"));
-
scoped_ptr<base::Value> json_value(
base::JSONReader::Read(languages_json, base::JSON_ALLOW_TRAILING_COMMAS));
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/422577 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "422577 TranslateLanguageList::SetSupportedLanguages 3"));
-
if (json_value == NULL || !json_value->IsType(base::Value::TYPE_DICTIONARY)) {
NOTREACHED();
return;

Powered by Google App Engine
This is Rietveld 408576698