Issue 7013059: Fix base::internal::WeakReferenceOwner races.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7013059: Fix base::internal::WeakReferenceOwner races. (Closed)

Created:
9 years, 7 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix base::internal::WeakReferenceOwner races. base::WeakPtr is thread unsafe, in that its getters must all be called on the same thread. However, we want it to be deletable on different threads. Therefore, we need some locks. BUG=82509 TEST=none

Patch Set 1 #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -2 lines)			Patch
M	base/memory/weak_ptr.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	base/memory/weak_ptr.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	base/memory/weak_ptr_unittest.cc	View	3 chunks	+17 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 7 months ago (2011-05-15 21:13:26 UTC) #2

I'm scrapping this changelist. It's broken. We're already in the destructor of
Flag, so the lock will prevent data races, but it might cause the pointer to
point to an already destructed object. A different fix is needed.

Expand Messages | Collapse Messages