base/memory/weak_ptr.cc - Issue 7013059: Fix base::internal::WeakReferenceOwner races.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/weak_ptr.cc

Issue 7013059: Fix base::internal::WeakReferenceOwner races. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/weak_ptr.cc

diff --git a/base/memory/weak_ptr.cc b/base/memory/weak_ptr.cc

index 30c777c00cf1b373e17b6c811e9aaf71fab86f11..6cf469b4a27d35991e96b0c31a0935188c029d9a 100644

--- a/base/memory/weak_ptr.cc

+++ b/base/memory/weak_ptr.cc

@@ -46,6 +46,7 @@ WeakReferenceOwner::~WeakReferenceOwner() {

}

WeakReference WeakReferenceOwner::GetRef() const {

+ AutoLock auto_lock(lock_);

if (!flag_)

flag_ = new WeakReference::Flag(&flag_);

return WeakReference(flag_);

« no previous file with comments | « base/memory/weak_ptr.h ('k') | base/memory/weak_ptr_unittest.cc » ('j') | no next file with comments »