Issue 7013051: Do not sync prefs::kLanguagePreloadEngines and prefs::kLanguagePreferredLanguages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7013051: Do not sync prefs::kLanguagePreloadEngines and prefs::kLanguagePreferredLanguages. (Closed)

Created:
9 years, 7 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
Zachary Kuznia

CC:
chromium-reviews, davemoore+watch_chromium.org, mazda

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Do not sync prefs::kLanguagePreloadEngines and prefs::kLanguagePreferredLanguages. Syncing the list of keyboard layouts and input methods is not good for users who have 2+ devices with different hardware keyboards (e.g. US Qwerty and GB). BUG=chromium-os:15181 TEST=manually confirmed that the list is no longer synced. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85463

Patch Set 1 #

Total comments: 2

Patch Set 2 : review fix #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/chromeos/preferences.cc	View	1	2 chunks	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

lgtm http://codereview.chromium.org/7013051/diff/1/chrome/browser/chromeos/preferences.cc File chrome/browser/chromeos/preferences.cc (right): http://codereview.chromium.org/7013051/diff/1/chrome/browser/chromeos/preferences.cc#newcode60 chrome/browser/chromeos/preferences.cc:60: // We don't sync prefs::kLanguageCurrentInputMethod and PreviousInputMethod. nit: ...

9 years, 7 months ago (2011-05-16 01:50:30 UTC) #2

Yusuke Sato

9 years, 7 months ago (2011-05-16 06:23:43 UTC) #3

http://codereview.chromium.org/7013051/diff/1/chrome/browser/chromeos/prefere...
File chrome/browser/chromeos/preferences.cc (right):

http://codereview.chromium.org/7013051/diff/1/chrome/browser/chromeos/prefere...
chrome/browser/chromeos/preferences.cc:60: // We don't sync
prefs::kLanguageCurrentInputMethod and PreviousInputMethod.
On 2011/05/16 01:50:31, Zachary Kuznia wrote:
> nit: Could you add that we don't sync these because they're just used to track
> the logout state of the device?

Done.

Expand Messages | Collapse Messages