content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h - Issue 701033005: content: Move type selection logic out of GpuMemoryBufferImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

Issue 701033005: content: Move type selection logic out of GpuMemoryBufferImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc ('k') | content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

index 57256347ca8fff27b85e91dfb3199911ffdda924..80c67426bd2c30b6abc77c15b8d827eeefad073c 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h

@@ -38,14 +38,12 @@ class GpuMemoryBufferImplSurfaceTexture : public GpuMemoryBufferImpl {

static bool IsFormatSupported(Format format);

static bool IsUsageSupported(Usage usage);

- static bool IsConfigurationSupported(Format format, Usage usage);

- static int WindowFormat(Format format);

// Overridden from gfx::GpuMemoryBuffer:

- virtual void* Map() override;

- virtual void Unmap() override;

- virtual gfx::GpuMemoryBufferHandle GetHandle() const override;

- virtual uint32 GetStride() const override;

+ void* Map() override;

+ void Unmap() override;

+ gfx::GpuMemoryBufferHandle GetHandle() const override;

+ uint32 GetStride() const override;

private:

GpuMemoryBufferImplSurfaceTexture(gfx::GpuMemoryBufferId id,

@@ -53,7 +51,9 @@ class GpuMemoryBufferImplSurfaceTexture : public GpuMemoryBufferImpl {

Format format,

const DestructionCallback& callback,

ANativeWindow* native_window);

- virtual ~GpuMemoryBufferImplSurfaceTexture();

+ ~GpuMemoryBufferImplSurfaceTexture() override;

+ static int WindowFormat(Format format);

ANativeWindow* native_window_;

size_t stride_;