content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc - Issue 701033005: content: Move type selection logic out of GpuMemoryBufferImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

Issue 701033005: content: Move type selection logic out of GpuMemoryBufferImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review feedback Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h ('k') | content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

index 28282729215cd3aa16e2fddbeda9bd31735a5a05..4ec2b79a3dff67ddcbf111caad873338330e7e75 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc

@@ -158,12 +158,6 @@ bool GpuMemoryBufferImplSurfaceTexture::IsUsageSupported(Usage usage) {

}

// static

-bool GpuMemoryBufferImplSurfaceTexture::IsConfigurationSupported(Format format,

- Usage usage) {

- return IsFormatSupported(format) && IsUsageSupported(usage);

-// static

int GpuMemoryBufferImplSurfaceTexture::WindowFormat(Format format) {

switch (format) {

case RGBA_8888: