Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 700943003: Fix issue 19424 (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 2

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-04 22:53:54 UTC) #2
Paul Berry
It would be nice to also add a unit test so that we can confirm ...
6 years, 1 month ago (2014-11-04 23:07:41 UTC) #3
Brian Wilkerson
Tests added. https://codereview.chromium.org/700943003/diff/20001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java (right): https://codereview.chromium.org/700943003/diff/20001/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java#newcode200 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:200: private final Identifier identifier; I renamed it.
6 years, 1 month ago (2014-11-05 17:05:25 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-11-05 17:06:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698