Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 700923002: Warn when implicit default value overrides explicit one that differs. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Warn when implicit default value overrides explicit one that differs. BUG=dartbug.com/18914 R=brianwilkerson@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41503

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -35 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 2 chunks +10 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 1 chunk +9 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +106 lines, -0 lines 2 comments Download
M tests/co19/co19-analyzer2.status View 2 chunks +0 lines, -5 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/super_bound_closure_test.dart View 2 chunks +26 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
6 years, 1 month ago (2014-11-04 18:35:09 UTC) #2
scheglov
LGTM https://codereview.chromium.org/700923002/diff/1/pkg/analyzer/test/generated/static_warning_code_test.dart File pkg/analyzer/test/generated/static_warning_code_test.dart (right): https://codereview.chromium.org/700923002/diff/1/pkg/analyzer/test/generated/static_warning_code_test.dart#newcode1762 pkg/analyzer/test/generated/static_warning_code_test.dart:1762: assertNoErrors(source); Test cases without errors should be added ...
6 years, 1 month ago (2014-11-04 18:43:21 UTC) #3
Brian Wilkerson
LGTM https://codereview.chromium.org/700923002/diff/1/pkg/analyzer/test/generated/static_warning_code_test.dart File pkg/analyzer/test/generated/static_warning_code_test.dart (right): https://codereview.chromium.org/700923002/diff/1/pkg/analyzer/test/generated/static_warning_code_test.dart#newcode1748 pkg/analyzer/test/generated/static_warning_code_test.dart:1748: void test_invalidOverride_defaultOverridesNonDefaultNull() { I'm not sure whether we ...
6 years, 1 month ago (2014-11-04 18:46:42 UTC) #5
Paul Berry
6 years, 1 month ago (2014-11-04 20:32:26 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41503 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698