Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: PRESUBMIT.py

Issue 700763002: More Windows build fixes, some tidying in mojo_main (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: reland: fix sense in mojo/shell Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index a28b9b1384e00456d159b3ee5cb37e313301577c..1f9156c4f35fc187e3f5ac4c73d75799264365bc 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -444,9 +444,12 @@ def _CheckGNCheck(input_api, output_api):
# TODO(eseidel): Currently only these are known to pass,
# once everything passes we can just call 'gn check' once without a filter!
KNOWN_PASSING = [
- '//sky/*',
'//mojo/public/*',
]
+ if input_api.platform != 'win32':
+ KNOWN_PASSING += [
+ '//sky/*',
+ ]
for target_filter in KNOWN_PASSING:
try:
input_api.subprocess.check_output(['gn', 'check', relative_out_dir,
« no previous file with comments | « BUILD.gn ('k') | base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698