| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 437 relative_out_dir = input_api.os_path.relpath(out_dir, temp_parent) | 437 relative_out_dir = input_api.os_path.relpath(out_dir, temp_parent) |
| 438 try: | 438 try: |
| 439 input_api.subprocess.check_output(['gn', 'gen', relative_out_dir]) | 439 input_api.subprocess.check_output(['gn', 'gen', relative_out_dir]) |
| 440 except input_api.subprocess.CalledProcessError, error: | 440 except input_api.subprocess.CalledProcessError, error: |
| 441 return [output_api.PresubmitError( | 441 return [output_api.PresubmitError( |
| 442 'gn gen must not fail.', long_text=error.output)] | 442 'gn gen must not fail.', long_text=error.output)] |
| 443 | 443 |
| 444 # TODO(eseidel): Currently only these are known to pass, | 444 # TODO(eseidel): Currently only these are known to pass, |
| 445 # once everything passes we can just call 'gn check' once without a filter! | 445 # once everything passes we can just call 'gn check' once without a filter! |
| 446 KNOWN_PASSING = [ | 446 KNOWN_PASSING = [ |
| 447 '//sky/*', | |
| 448 '//mojo/public/*', | 447 '//mojo/public/*', |
| 449 ] | 448 ] |
| 449 if input_api.platform != 'win32': |
| 450 KNOWN_PASSING += [ |
| 451 '//sky/*', |
| 452 ] |
| 450 for target_filter in KNOWN_PASSING: | 453 for target_filter in KNOWN_PASSING: |
| 451 try: | 454 try: |
| 452 input_api.subprocess.check_output(['gn', 'check', relative_out_dir, | 455 input_api.subprocess.check_output(['gn', 'check', relative_out_dir, |
| 453 target_filter]) | 456 target_filter]) |
| 454 except input_api.subprocess.CalledProcessError, error: | 457 except input_api.subprocess.CalledProcessError, error: |
| 455 error_title = 'gn check %s must not fail.' % target_filter | 458 error_title = 'gn check %s must not fail.' % target_filter |
| 456 return [output_api.PresubmitError(error_title, long_text=error.output)] | 459 return [output_api.PresubmitError(error_title, long_text=error.output)] |
| 457 return [] | 460 return [] |
| 458 | 461 |
| 459 | 462 |
| (...skipping 1284 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1744 builders.extend(['cros_x86']) | 1747 builders.extend(['cros_x86']) |
| 1745 | 1748 |
| 1746 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it | 1749 # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it |
| 1747 # unless they're .gyp(i) files as changes to those files can break the gyp | 1750 # unless they're .gyp(i) files as changes to those files can break the gyp |
| 1748 # step on that bot. | 1751 # step on that bot. |
| 1749 if (not all(re.search('^chrome', f) for f in files) or | 1752 if (not all(re.search('^chrome', f) for f in files) or |
| 1750 any(re.search('\.gypi?$', f) for f in files)): | 1753 any(re.search('\.gypi?$', f) for f in files)): |
| 1751 builders.extend(['android_aosp']) | 1754 builders.extend(['android_aosp']) |
| 1752 | 1755 |
| 1753 return GetDefaultTryConfigs(builders) | 1756 return GetDefaultTryConfigs(builders) |
| OLD | NEW |