Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 700763002: More Windows build fixes, some tidying in mojo_main (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
Reviewers:
jamesr, jam
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

More Windows build fixes, some tidying in mojo_main - Forced x64 (to avoid .asm build problems) - Removed Sky as they're not interested in building/maintaining Windows at this point - Misc Windows compile errors R=jam@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c2d46e5a3882f80ffa3d8d50a39fa0b5a1271628 Committed: https://chromium.googlesource.com/external/mojo/+/3582083ef006382cdc9ba0bf364ee132441c7288

Patch Set 1 #

Patch Set 2 : .gitignore #

Total comments: 2

Patch Set 3 : reland: fix sense in mojo/shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -16 lines) Patch
M .gitignore View 1 2 chunks +2 lines, -0 lines 0 comments Download
M BUILD.gn View 1 chunk +7 lines, -1 line 0 comments Download
M PRESUBMIT.py View 1 chunk +4 lines, -1 line 0 comments Download
M base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +2 lines, -1 line 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/shell/desktop/mojo_main.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/shell/domain_socket/net_errors.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/shell/incoming_connection_listener_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M mojo/shell/launcher_main.cc View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
scottmg
6 years, 1 month ago (2014-11-04 18:17:31 UTC) #1
jam
lgtm
6 years, 1 month ago (2014-11-04 18:43:26 UTC) #2
scottmg
Committed patchset #2 (id:20001) manually as c2d46e5a3882f80ffa3d8d50a39fa0b5a1271628.
6 years, 1 month ago (2014-11-04 18:44:59 UTC) #3
jamesr
https://codereview.chromium.org/700763002/diff/20001/mojo/shell/BUILD.gn File mojo/shell/BUILD.gn (right): https://codereview.chromium.org/700763002/diff/20001/mojo/shell/BUILD.gn#newcode123 mojo/shell/BUILD.gn:123: deps -= [ += ?
6 years, 1 month ago (2014-11-04 18:56:06 UTC) #5
scottmg
https://codereview.chromium.org/700763002/diff/20001/mojo/shell/BUILD.gn File mojo/shell/BUILD.gn (right): https://codereview.chromium.org/700763002/diff/20001/mojo/shell/BUILD.gn#newcode123 mojo/shell/BUILD.gn:123: deps -= [ On 2014/11/04 18:56:06, jamesr wrote: > ...
6 years, 1 month ago (2014-11-04 18:57:19 UTC) #6
scottmg
ps3 for reland
6 years, 1 month ago (2014-11-04 19:01:19 UTC) #7
scottmg
6 years, 1 month ago (2014-11-04 19:04:08 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3582083ef006382cdc9ba0bf364ee132441c7288.

Powered by Google App Engine
This is Rietveld 408576698