Source/bindings/templates/union.h - Issue 700733003: IDL: Support union type arrays and sequences for method arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/union.h

Issue 700733003: IDL: Support union type arrays and sequences for method arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/dom/idl-union-type-unittest-expected.txt ('k') | Source/bindings/templates/union.cpp » ('j') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/templates/union.h

diff --git a/Source/bindings/templates/union.h b/Source/bindings/templates/union.h

index bfef378f9d4276480135c458b936e2d72fb95743..a5a42a78010562689e0efdfb3281b33fffcd5109 100644

--- a/Source/bindings/templates/union.h

+++ b/Source/bindings/templates/union.h

@@ -63,6 +63,11 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{container.cpp_c

v8SetReturnValue(callbackInfo, toV8(impl, callbackInfo.Holder(), callbackInfo.GetIsolate()));

}

+template <>

+struct NativeValueTraits<{{container.cpp_class}}> {

+ static {{container.cpp_class}} nativeValue(const v8::Handle<v8::Value>&, v8::Isolate*, ExceptionState&);

+};

{% endfor %}

{% for cpp_type in nullable_cpp_types %}

class V8{{cpp_type}}OrNull final {