Source/bindings/tests/results/core/V8TestInterface.cpp - Issue 700733003: IDL: Support union type arrays and sequences for method arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface.cpp

Issue 700733003: IDL: Support union type arrays and sequences for method arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/tests/results/core/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface.cpp b/Source/bindings/tests/results/core/V8TestInterface.cpp

index fb1eccb5cbd2d2b624588c910cef1aeb2812769c..74c475804f257374f4c13331cc2b6ce809981b3e 100644

--- a/Source/bindings/tests/results/core/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface.cpp

@@ -1161,7 +1161,7 @@ static void promiseMethodPartialOverload1Method(const v8::FunctionCallbackInfo<v

static void promiseMethodPartialOverload2Method(const v8::FunctionCallbackInfo<v8::Value>& info)

{

TestInterfaceImplementation* impl = V8TestInterface::toImpl(info.Holder());

- LocalDOMWindow* window;

+ DOMWindow* window;

bashi 2014/11/11 01:34:46 This was fixed by another CL. Will rebase.

{

if (info.Length() > 0 && !V8Window::hasInstance(info[0], info.GetIsolate())) {

v8SetReturnValue(info, ScriptPromise::rejectRaw(info.GetIsolate(), V8ThrowException::createTypeError(info.GetIsolate(), ExceptionMessages::failedToExecute("promiseMethodPartialOverload", "TestInterface", "parameter 1 is not of type 'Window'."))));

« no previous file with comments | « Source/bindings/tests/results/core/UnionTypesCore.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »