Track initializers already seen (fixes #21439)

Track initializers already seen (fixes #21439)

R=jakemac@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41499

[Siggi Cherem (dart-lang), 2014-11-04 02:55:58]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2014-11-04 03:00:01]

sigmund@google.com changed reviewers:
+ jakemac@google.com

[Siggi Cherem (dart-lang), 2014-11-04 03:00:01]

https://codereview.chromium.org/700733002/diff/20001/pkg/polymer/test/build/s...
File pkg/polymer/test/build/script_compactor_test.dart (right):

https://codereview.chromium.org/700733002/diff/20001/pkg/polymer/test/build/s...
pkg/polymer/test/build/script_compactor_test.dart:257: 'export "i.dart" hide
mI2;\n'
BTW, this is why I keep track of seen classes/functions. Initially I was just
checking for libraries we've already seen, but turns out that the show/hide
directives make it so that we need to check at a fine-grain level to get it
right

[jakemac, 2014-11-04 17:45:54]

lgtm

https://codereview.chromium.org/700733002/diff/40001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/script_compactor.dart (right):

https://codereview.chromium.org/700733002/diff/40001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/script_compactor.dart:835: addAllNew(list) =>
list.forEach((e) {
I would probably break this out into a function that takes a set and a list as
inputs and returns the new list since its the same as above.

Iterable getAllNew(Iterable existing, Iterable new) {
  return new.where((e) => !existing.contains(e));
}

[Siggi Cherem (dart-lang), 2014-11-04 17:54:23]

Patchset #3 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2014-11-04 17:55:08]

thanks!

https://codereview.chromium.org/700733002/diff/40001/pkg/polymer/lib/src/buil...
File pkg/polymer/lib/src/build/script_compactor.dart (right):

https://codereview.chromium.org/700733002/diff/40001/pkg/polymer/lib/src/buil...
pkg/polymer/lib/src/build/script_compactor.dart:835: addAllNew(list) =>
list.forEach((e) {
On 2014/11/04 17:45:54, jakemac wrote:
> I would probably break this out into a function that takes a set and a list as
> inputs and returns the new list since its the same as above.
> 
> Iterable getAllNew(Iterable existing, Iterable new) {
>   return new.where((e) => !existing.contains(e));
> }

good point - this made me realize that I could just do the filtering above
without passing the set argument on these functions at all. It's much simpler
now. Thanks!

[Siggi Cherem (dart-lang), 2014-11-04 18:34:13]

Committed patchset #3 (id:80001) manually as 41499 (presubmit successful).