Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7476)

Unified Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

Issue 700673003: Add metrics to all items in the 'wrench' menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add WrenchMenu.TimeToAction timings histogram Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
diff --git a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
index b1eb408b87bcf53e3eee013755a353e488facd51..c057668b8306c3ca04475ea2bb5a40ec9e8de6a0 100644
--- a/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
+++ b/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h
@@ -9,6 +9,7 @@
#include "base/memory/weak_ptr.h"
#include "base/task/cancelable_task_tracker.h"
+#include "base/timer/elapsed_timer.h"
#include "chrome/browser/favicon/favicon_service.h"
#include "chrome/browser/sessions/tab_restore_service.h"
#include "chrome/browser/sessions/tab_restore_service_observer.h"
@@ -168,6 +169,8 @@ class RecentTabsSubMenuModel : public ui::SimpleMenuModel,
base::WeakPtrFactory<RecentTabsSubMenuModel> weak_ptr_factory_;
+ base::ElapsedTimer timer;
Peter Kasting 2014/11/14 19:48:59 Nit: Give a more descriptive name and/or write a c
Alexei Svitkine (slow) 2014/11/15 00:00:16 Also, name should end with a _.
edwardjung 2014/11/17 15:58:23 Done.
edwardjung 2014/11/17 15:58:23 Done.
+
DISALLOW_COPY_AND_ASSIGN(RecentTabsSubMenuModel);
};
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('j') | chrome/browser/ui/toolbar/wrench_menu_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698