Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Side by Side Diff: chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.h

Issue 700673003: Add metrics to all items in the 'wrench' menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add WrenchMenu.TimeToAction timings histogram Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_TOOLBAR_RECENT_TABS_SUB_MENU_MODEL_H_ 5 #ifndef CHROME_BROWSER_UI_TOOLBAR_RECENT_TABS_SUB_MENU_MODEL_H_
6 #define CHROME_BROWSER_UI_TOOLBAR_RECENT_TABS_SUB_MENU_MODEL_H_ 6 #define CHROME_BROWSER_UI_TOOLBAR_RECENT_TABS_SUB_MENU_MODEL_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "base/task/cancelable_task_tracker.h" 11 #include "base/task/cancelable_task_tracker.h"
12 #include "base/timer/elapsed_timer.h"
12 #include "chrome/browser/favicon/favicon_service.h" 13 #include "chrome/browser/favicon/favicon_service.h"
13 #include "chrome/browser/sessions/tab_restore_service.h" 14 #include "chrome/browser/sessions/tab_restore_service.h"
14 #include "chrome/browser/sessions/tab_restore_service_observer.h" 15 #include "chrome/browser/sessions/tab_restore_service_observer.h"
15 #include "chrome/browser/sync/glue/synced_session.h" 16 #include "chrome/browser/sync/glue/synced_session.h"
16 #include "ui/base/accelerators/accelerator.h" 17 #include "ui/base/accelerators/accelerator.h"
17 #include "ui/base/models/simple_menu_model.h" 18 #include "ui/base/models/simple_menu_model.h"
18 19
19 class Browser; 20 class Browser;
20 struct SessionTab; 21 struct SessionTab;
21 22
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 // menumodel. 162 // menumodel.
162 int last_local_model_index_; 163 int last_local_model_index_;
163 164
164 gfx::Image default_favicon_; 165 gfx::Image default_favicon_;
165 166
166 base::CancelableTaskTracker local_tab_cancelable_task_tracker_; 167 base::CancelableTaskTracker local_tab_cancelable_task_tracker_;
167 base::CancelableTaskTracker other_devices_tab_cancelable_task_tracker_; 168 base::CancelableTaskTracker other_devices_tab_cancelable_task_tracker_;
168 169
169 base::WeakPtrFactory<RecentTabsSubMenuModel> weak_ptr_factory_; 170 base::WeakPtrFactory<RecentTabsSubMenuModel> weak_ptr_factory_;
170 171
172 base::ElapsedTimer timer;
Peter Kasting 2014/11/14 19:48:59 Nit: Give a more descriptive name and/or write a c
Alexei Svitkine (slow) 2014/11/15 00:00:16 Also, name should end with a _.
edwardjung 2014/11/17 15:58:23 Done.
edwardjung 2014/11/17 15:58:23 Done.
173
171 DISALLOW_COPY_AND_ASSIGN(RecentTabsSubMenuModel); 174 DISALLOW_COPY_AND_ASSIGN(RecentTabsSubMenuModel);
172 }; 175 };
173 176
174 #endif // CHROME_BROWSER_UI_TOOLBAR_RECENT_TABS_SUB_MENU_MODEL_H_ 177 #endif // CHROME_BROWSER_UI_TOOLBAR_RECENT_TABS_SUB_MENU_MODEL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/recent_tabs_sub_menu_model.cc » ('j') | chrome/browser/ui/toolbar/wrench_menu_model.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698