Issue 700603003: IDL: Add IdlTypeBase.is_traceable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700603003: IDL: Add IdlTypeBase.is_traceable (Closed)

Created:
6 years, 1 month ago by bashi

Modified:
6 years, 1 month ago

Reviewers:
haraken, Jens Widell

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

IDL: Add IdlTypeBase.is_traceable This is a follow-up CL of https://codereview.chromium.org/689013002 v8_union.py and v8_dictionary.py create a same flag from the same condition. This should be a property of IdlType. BUG=240176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184814

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -4 lines)			Patch
M	Source/bindings/scripts/v8_dictionary.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/bindings/scripts/v8_types.py	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	Source/bindings/scripts/v8_union.py	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700603003/1

6 years, 1 month ago (2014-11-04 02:31:43 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 184814

6 years, 1 month ago (2014-11-04 02:33:46 UTC) #6

Jens Widell

6 years, 1 month ago (2014-11-04 08:50:44 UTC) #7

Message was sent while issue was closed.

LGTM

Thanks for fixing this! I had made an identical change, but apparently forgot to
ever upload it...