Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 689013002: IDL: Generate trace() method in union container types when required (Closed)

Created:
6 years, 1 month ago by Jens Widell
Modified:
6 years, 1 month ago
Reviewers:
haraken, bashi
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Generate trace() method in union container types when required If any union member type needs tracing, generate a trace() method that does that tracing. BUG=240176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184699

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M Source/bindings/scripts/v8_union.py View 2 chunks +3 lines, -0 lines 2 comments Download
M Source/bindings/templates/union.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/bindings/templates/union.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/UnionTypesCore.cpp View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jens Widell
PTAL
6 years, 1 month ago (2014-10-31 07:22:50 UTC) #2
bashi
LGTM. Thank you for fixing this so fast!
6 years, 1 month ago (2014-10-31 07:27:37 UTC) #3
sof
https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_union.py File Source/bindings/scripts/v8_union.py (right): https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_union.py#newcode87 Source/bindings/scripts/v8_union.py:87: 'is_traceable': (member.is_garbage_collected or Might be worth lifting out into ...
6 years, 1 month ago (2014-10-31 07:30:12 UTC) #4
haraken
LGTM, thanks for the fix!
6 years, 1 month ago (2014-10-31 07:30:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/689013002/1
6 years, 1 month ago (2014-10-31 07:36:11 UTC) #7
Jens Widell
https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_union.py File Source/bindings/scripts/v8_union.py (right): https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_union.py#newcode87 Source/bindings/scripts/v8_union.py:87: 'is_traceable': (member.is_garbage_collected or On 2014/10/31 07:30:12, sof wrote: > ...
6 years, 1 month ago (2014-10-31 07:48:46 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 08:37:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184699

Powered by Google App Engine
This is Rietveld 408576698