IDL: Generate trace() method in union container types when required

IDL: Generate trace() method in union container types when required

If any union member type needs tracing, generate a trace() method that
does that tracing.

BUG=240176
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184699

[Jens Widell, 2014-10-31 07:22:49]

jl@opera.com changed reviewers:
+ bashi@chromium.org, haraken@chromium.org

[Jens Widell, 2014-10-31 07:22:50]

PTAL

[bashi, 2014-10-31 07:27:37]

LGTM. Thank you for fixing this so fast!

[sof, 2014-10-31 07:30:12]

https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_u...
File Source/bindings/scripts/v8_union.py (right):

https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_u...
Source/bindings/scripts/v8_union.py:87: 'is_traceable':
(member.is_garbage_collected or
Might be worth lifting out into a helper in v8_types, as it is used elsewhere
also?

[haraken, 2014-10-31 07:30:45]

LGTM, thanks for the fix!

[Jens Widell, 2014-10-31 07:35:53]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-10-31 07:36:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/689013002/1

[Jens Widell, 2014-10-31 07:48:46]

https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_u...
File Source/bindings/scripts/v8_union.py (right):

https://codereview.chromium.org/689013002/diff/1/Source/bindings/scripts/v8_u...
Source/bindings/scripts/v8_union.py:87: 'is_traceable':
(member.is_garbage_collected or
On 2014/10/31 07:30:12, sof wrote:
> Might be worth lifting out into a helper in v8_types, as it is used elsewhere
> also?

Yes. I'll follow up with that.

[commit-bot: I haz the power, 2014-10-31 08:37:15]

Committed patchset #1 (id:1) as 184699