Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 700523003: Classes: Partial fix for constructor not calling super (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Classes: Partial fix for constructor not calling super Introduce two new function kind, one for default constructor and one for default constructor call super. Then when we are about to pares these we just generate the correct AST in source. BUG=v8:3661, v8:3672 LOG=Y R=dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25222

Patch Set 1 #

Total comments: 2

Patch Set 2 : Set the position of the default constructor to the position of the class #

Patch Set 3 : #

Patch Set 4 : remove todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -46 lines) Patch
M src/ast.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/code-stubs.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/full-codegen.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M src/globals.h View 1 2 3 3 chunks +18 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +8 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +10 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/parser.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/parser.cc View 1 2 3 3 chunks +68 lines, -0 lines 0 comments Download
M src/preparser.h View 1 3 chunks +13 lines, -0 lines 0 comments Download
M src/runtime/runtime-classes.cc View 2 chunks +23 lines, -30 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
arv (Not doing code reviews)
This now works. I want to do some refactoring and handle the todos. Is this ...
6 years, 1 month ago (2014-11-07 00:03:04 UTC) #2
Dmitry Lomov (no reviews)
Overall a right direction, but let's try to position default constructors in the source - ...
6 years, 1 month ago (2014-11-07 07:01:11 UTC) #3
arv (Not doing code reviews)
PTAL
6 years, 1 month ago (2014-11-07 15:36:03 UTC) #4
arv (Not doing code reviews)
remove todo
6 years, 1 month ago (2014-11-07 15:38:12 UTC) #5
Dmitry Lomov (no reviews)
lgtm
6 years, 1 month ago (2014-11-07 16:32:02 UTC) #6
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-07 16:39:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 25222 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698