src/full-codegen.cc - Issue 700523003: Classes: Partial fix for constructor not calling super

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen.cc

Issue 700523003: Classes: Partial fix for constructor not calling super (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: remove todo Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen.cc

diff --git a/src/full-codegen.cc b/src/full-codegen.cc

index 58e5e978abf2dd7b73363378ccef7d1d4e9780f6..01f2fafefa6429e66ca7644893a368c9bdde0dc6 100644

--- a/src/full-codegen.cc

+++ b/src/full-codegen.cc

@@ -1575,11 +1575,7 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {

__ Push(isolate()->factory()->the_hole_value());

}

- if (lit->constructor() != NULL) {

- VisitForStackValue(lit->constructor());

- } else {

- __ Push(isolate()->factory()->undefined_value());

- }

+ VisitForStackValue(lit->constructor());

__ Push(script());

__ Push(Smi::FromInt(lit->start_position()));

« no previous file with comments | « src/code-stubs.h ('k') | src/globals.h » ('j') | no next file with comments »