Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 700503002: Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. (Closed)

Created:
6 years, 1 month ago by mcasas
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. YCWebCameraSource.ax causes a huge amount of Chrome crashes. This CL changes the initialization model of the Device Thread, a.k.a Audio Thread, from Multiple Thread appartment model to Single Thread model, MTA -> STA. We'll monitor the crash rate in the Canaries to see if it has the desired effect. BUG=427192, 421991 Adding this since the android_dbg_tests_recipe bot seems stalled. NOTRY=true Committed: https://crrev.com/90ec5d341eb859647217c371dbe2508f1c838827 Cr-Commit-Position: refs/heads/master@{#302596}

Patch Set 1 #

Patch Set 2 : Sorted out MediaStreamDispatcherHostTest and VCM::Unregister() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 3 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
mcasas
tommi@ PTAL. (I need to figure one thread issue in a particular bot+content_unittests but otherwise ...
6 years, 1 month ago (2014-11-03 12:21:27 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 1 month ago (2014-11-03 16:29:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700503002/20001
6 years, 1 month ago (2014-11-03 16:41:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700503002/20001
6 years, 1 month ago (2014-11-04 07:03:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/700503002/20001
6 years, 1 month ago (2014-11-04 10:16:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 10:18:00 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/90ec5d341eb859647217c371dbe2508f1c838827 Cr-Commit-Position: refs/heads/master@{#302596}
6 years, 1 month ago (2014-11-04 10:18:41 UTC) #15
Bernhard Bauer
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/702703002/ by bauerb@chromium.org. ...
6 years, 1 month ago (2014-11-04 14:32:23 UTC) #16
Bernhard Bauer
Which run of android_dbg_tests_recipe seemed stalled? http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/24965 took 48 minutes to finish, which seems to ...
6 years, 1 month ago (2014-11-04 15:47:42 UTC) #17
mcasas
6 years, 1 month ago (2014-11-04 15:58:35 UTC) #18
Message was sent while issue was closed.
On 2014/11/04 15:47:42, Bernhard Bauer wrote:
> Which run of android_dbg_tests_recipe seemed stalled?
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...
> took 48 minutes to finish, which seems to be normal (according to
>
http://build.chromium.org/p/tryserver.chromium.linux/stats/android_dbg_tests_...).

The one overnight did not seem to finish correctly (#5).
Never mind, I've got another CL in the making for this.
(https://codereview.chromium.org/706443002)

Powered by Google App Engine
This is Rietveld 408576698