Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 706443002: Retry: Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. (Closed)

Created:
6 years, 1 month ago by mcasas
Modified:
6 years, 1 month ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Retry: Win Video Capture: Create an STA |video_capture_thread_| from MediaStreamManager. (This CL is tries to fix http://crrev.com/700503002 that was reverted due to some failing Android content_browsertests.) Original message ------------------------------------------------------ YCWebCameraSource.ax causes a huge amount of Chrome crashes. This CL changes the initialization model of the Device Thread, a.k.a Audio Thread, from Multiple Thread appartment model to Single Thread model, MTA -> STA. We'll monitor the crash rate in the Canaries to see if it has the desired effect. BUG=427192, 421991 Committed: https://crrev.com/ac1db38b82e5dfdddced45bc77e126a85ef01ce0 Cr-Commit-Position: refs/heads/master@{#302689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 3 chunks +15 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_manager.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tommi (sloooow) - chröme
lgtm
6 years, 1 month ago (2014-11-04 16:20:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706443002/1
6 years, 1 month ago (2014-11-04 21:12:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 22:31:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 22:32:38 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac1db38b82e5dfdddced45bc77e126a85ef01ce0
Cr-Commit-Position: refs/heads/master@{#302689}

Powered by Google App Engine
This is Rietveld 408576698