chromeos/network/shill_property_util.cc - Issue 700383008: Use setProperties for Cellular APN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/shill_property_util.cc

Issue 700383008: Use setProperties for Cellular APN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_2

Patch Set: Allow Cellular in shill_property_util::CopyIdentifyingProperties to fix unit test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chromeos/network/shill_property_util.cc

diff --git a/chromeos/network/shill_property_util.cc b/chromeos/network/shill_property_util.cc

index 7557dc35414c129a430183912e0ca9f21953eeaf..798245990b3a0624958dc2d3fc70cf064071f735 100644

--- a/chromeos/network/shill_property_util.cc

+++ b/chromeos/network/shill_property_util.cc

@@ -247,6 +247,9 @@ bool CopyIdentifyingProperties(const base::DictionaryValue& service_properties,

CopyStringFromDictionary(service_properties, shill::kWifiHexSsid, dest);

success &= CopyStringFromDictionary(

service_properties, shill::kModeProperty, dest);

+ } else if (type == shill::kTypeCellular) {

+ success &= CopyStringFromDictionary(

+ service_properties, shill::kNetworkTechnologyProperty, dest);

} else if (type == shill::kTypeVPN) {

success &= CopyStringFromDictionary(

service_properties, shill::kNameProperty, dest);

« no previous file with comments | « chromeos/dbus/fake_shill_manager_client.cc ('k') | no next file » | no next file with comments »