chromeos/dbus/fake_shill_manager_client.cc - Issue 700383008: Use setProperties for Cellular APN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_manager_client.cc

Issue 700383008: Use setProperties for Cellular APN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_2

Patch Set: Allow Cellular in shill_property_util::CopyIdentifyingProperties to fix unit test Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('k') | chromeos/network/shill_property_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/dbus/fake_shill_manager_client.cc

diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc

index 99a83b23da7290c677cf6f7e97d6a0dc500e9482..f687cc80e808ca18628d164b251008437764c350 100644

--- a/chromeos/dbus/fake_shill_manager_client.cc

+++ b/chromeos/dbus/fake_shill_manager_client.cc

@@ -767,6 +767,9 @@ void FakeShillManagerClient::SetupDefaultEnvironment() {

state,

add_to_visible);

base::StringValue technology_value(shill::kNetworkTechnologyGsm);

+ devices->SetDeviceProperty("/device/cellular1",

+ shill::kTechnologyFamilyProperty,

+ technology_value);

services->SetServiceProperty(kCellularServicePath,

shill::kNetworkTechnologyProperty,

technology_value);

@@ -789,6 +792,7 @@ void FakeShillManagerClient::SetupDefaultEnvironment() {

services->SetServiceProperty(kCellularServicePath,

shill::kRoamingStateProperty,

base::StringValue(shill::kRoamingStateHome));

+ profiles->AddService(shared_profile, kCellularServicePath);

}

// VPN

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc ('k') | chromeos/network/shill_property_util.cc » ('j') | no next file with comments »