minidump/minidump_system_info_writer_test.cc - Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: minidump/minidump_system_info_writer_test.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: minidump/minidump_system_info_writer_test.cc

diff --git a/minidump/minidump_system_info_writer_test.cc b/minidump/minidump_system_info_writer_test.cc

index 8f96bda71bda7dd848e1788e447178ad4403ff7c..4575b512756917df1dd0c1b96713a310064b9ad5 100644

--- a/minidump/minidump_system_info_writer_test.cc

+++ b/minidump/minidump_system_info_writer_test.cc

@@ -279,7 +279,7 @@ TEST(MinidumpSystemInfoWriter, InitializeFromSnapshot_X86) {

const uint8_t kCPUStepping = 1;

const uint8_t kCPUBasicFamily =

- std::min(kCPUFamily, static_cast<uint16_t>(15));

+ std::min(kCPUFamily, implicit_cast<uint16_t>(15));

const uint8_t kCPUExtendedFamily = kCPUFamily - kCPUBasicFamily;

// These checks ensure that even if the constants above change, they represent

« client/simple_string_dictionary.h ('K') | « minidump/minidump_system_info_writer.cc ('k') | minidump/test/minidump_writable_test_util.cc » ('j') | no next file with comments »