Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: minidump/minidump_module_writer.cc

Issue 700383007: Use implicit_cast<> instead of static_cast<> whenever possible (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: minidump/minidump_module_writer.cc
diff --git a/minidump/minidump_module_writer.cc b/minidump/minidump_module_writer.cc
index 433121ba5164df2dbddc6c87f6db834548f3b086..4d0e5d2b494b9b2c4854cc9345b50aae9183242c 100644
--- a/minidump/minidump_module_writer.cc
+++ b/minidump/minidump_module_writer.cc
@@ -293,9 +293,9 @@ void MinidumpModuleWriter::SetFileVersion(uint16_t version_0,
DCHECK_EQ(state(), kStateMutable);
module_.VersionInfo.dwFileVersionMS =
- (static_cast<uint32_t>(version_0) << 16) | version_1;
+ (implicit_cast<uint32_t>(version_0) << 16) | version_1;
module_.VersionInfo.dwFileVersionLS =
- (static_cast<uint32_t>(version_2) << 16) | version_3;
+ (implicit_cast<uint32_t>(version_2) << 16) | version_3;
}
void MinidumpModuleWriter::SetProductVersion(uint16_t version_0,
@@ -305,9 +305,9 @@ void MinidumpModuleWriter::SetProductVersion(uint16_t version_0,
DCHECK_EQ(state(), kStateMutable);
module_.VersionInfo.dwProductVersionMS =
- (static_cast<uint32_t>(version_0) << 16) | version_1;
+ (implicit_cast<uint32_t>(version_0) << 16) | version_1;
module_.VersionInfo.dwProductVersionLS =
- (static_cast<uint32_t>(version_2) << 16) | version_3;
+ (implicit_cast<uint32_t>(version_2) << 16) | version_3;
}
void MinidumpModuleWriter::SetFileFlagsAndMask(uint32_t file_flags,

Powered by Google App Engine
This is Rietveld 408576698