Use implicit_cast<> instead of static_cast<> whenever possible

client/simple_string_dictionary.h

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 213 matching lines @@
     if (!key) {
       return;
     }
 
     Entry* entry = GetEntryForKey(key);
     if (entry) {
       entry->key[0] = '\0';
       entry->value[0] = '\0';
     }
 
-    DCHECK_EQ(GetEntryForKey(key), static_cast<Entry*>(nullptr));
+    DCHECK_EQ(GetEntryForKey(key), implicit_cast<Entry*>(nullptr));

[Robert Sesek, 2014/11/06 19:52:26]

Is this cast necessary with nullptr?

[Mark Mentovai, 2014/11/06 21:44:35]

Robert Sesek wrote:
Unfortunately, it still is.

   }
 
   //! \brief Returns a serialized form of the map.
   //!
   //! Places a serialized version of the map into \a map and returns the size in
   //! bytes. Both \a map and the size should be passed to the deserializing
   //! constructor. Note that the serialized \a map is scoped to the lifetime of
   //! the non-serialized instance of this class. The \a map data can be copied
   //! across IPC boundaries.
   size_t Serialize(const SerializedSimpleStringDictionary** map) const {
@@ skipping 20 matching lines @@
 
 //! \brief A TSimpleStringDictionary with default template parameters.
 //!
 //! For historical reasons this specialized version is available with the same
 //! size factors as a previous implementation.
 using SimpleStringDictionary = TSimpleStringDictionary<256, 256, 64>;
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_CLIENT_SIMPLE_STRING_DICTIONARY_H_