Issue 7003150: Merge 88759 - CrOS - Fix crash when pressing Enter in file browser dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7003150: Merge 88759 - CrOS - Fix crash when pressing Enter in file browser dialog (Closed)

Created:
9 years, 6 months ago by James Cook

Modified:
9 years, 6 months ago

Reviewers:
James Cook

CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/782/src/

Visibility:
Public.

Description

Merge 88759 - CrOS - Fix crash when pressing Enter in file browser dialog If focus is on the cancel button, pressing enter will both cancel the dialog and attempt to select a file. Fix by ensuring that SelectFileDialog::Listener objects are invoked exactly once (some listeners delete themselves after being invoked). BUG=chromium-os:16349 TEST=manual, see bug. Also browsertest FileManagerDialogTest.* Review URL: http://codereview.chromium.org/7108066 TBR=jamescook@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88857

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -5 lines)			Patch
M	chrome/browser/extensions/extension_file_browser_private_api.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.cc	View		4 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/file_manager_dialogs.cc	View	1	3 chunks	+20 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages