CrOS - Fix crash when pressing Enter in file browser dialog

CrOS - Fix crash when pressing Enter in file browser dialog

If focus is on the cancel button, pressing enter will both cancel the dialog and attempt to select a file.  Fix by ensuring that SelectFileDialog::Listener objects are invoked exactly once (some listeners delete themselves after being invoked).

BUG=chromium-os:16349
TEST=manual, see bug.  Also browsertest FileManagerDialogTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88759

[James Cook, 2011-06-10 22:02:53]

Achuith, I think these issues could be the source of some of our trouble with
the file browser.  Please have a look.

[achuithb, 2011-06-10 22:09:40]

LGTM.

http://codereview.chromium.org/7108066/diff/2001/chrome/browser/resources/fil...
File chrome/browser/resources/file_manager/js/file_manager.js (right):

http://codereview.chromium.org/7108066/diff/2001/chrome/browser/resources/fil...
chrome/browser/resources/file_manager/js/file_manager.js:2015:
event.preventDefault();
Run this by rginda to make sure this is fine.

http://codereview.chromium.org/7108066/diff/2001/chrome/browser/ui/views/file...
File chrome/browser/ui/views/file_manager_dialog.cc (right):

http://codereview.chromium.org/7108066/diff/2001/chrome/browser/ui/views/file...
chrome/browser/ui/views/file_manager_dialog.cc:25: // Returns the browser
represented by |window| or NULL if not found.
Add a TODO to move this code to browser_list.h which is a better home for this.

http://codereview.chromium.org/7108066/diff/2001/chrome/browser/ui/views/file...
chrome/browser/ui/views/file_manager_dialog.cc:97: if (!owner_browser) {
A DCHECK is probably appropriate here.