Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: scripts/slave/recipes/chromium_gn.py

Issue 700053006: Remove the Win GN bots from the FYI waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/chromium_gn.py
diff --git a/scripts/slave/recipes/chromium_gn.py b/scripts/slave/recipes/chromium_gn.py
index 9e9163c5ea97511c329f22435e0df1a13d106bec..0ca9dbc2ea6076b09f58a5d7de47d80e7098e7ce 100644
--- a/scripts/slave/recipes/chromium_gn.py
+++ b/scripts/slave/recipes/chromium_gn.py
@@ -168,20 +168,6 @@ BUILDERS = {
},
},
},
- 'chromium.fyi': {
- 'builders': {
- 'Windows GN': {
- 'chromium_config_kwargs': {
- 'BUILD_CONFIG': 'Release',
- },
- },
- 'Windows GN (dbg)': {
- 'chromium_config_kwargs': {
- 'BUILD_CONFIG': 'Debug',
- },
- },
- },
- },
}
def GenSteps(api):
@@ -227,9 +213,10 @@ def GenSteps(api):
# TODO(scottmg): goma doesn't work on windows GN builds yet.
is_windows = 'Windows' in buildername
api.chromium.run_gn(use_goma=not is_windows)
- if is_windows:
- api.chromium.c.compile_py.compiler = None
- api.chromium.c.compile_py.goma_dir = None
+ # TODO(dpranke): reenable when we have bots again.
+ #if is_windows:
+ # api.chromium.c.compile_py.compiler = None
+ # api.chromium.c.compile_py.goma_dir = None
api.chromium.compile(targets=['all'])
« no previous file with comments | « masters/master.chromium.fyi/slaves.cfg ('k') | scripts/slave/recipes/chromium_gn.expected/full_chromium_fyi_Windows_GN.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698