Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: scripts/slave/recipes/chromium_gn.py

Issue 700053006: Remove the Win GN bots from the FYI waterfall. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 DEPS = [ 5 DEPS = [
6 'bot_update', 6 'bot_update',
7 'chromium', 7 'chromium',
8 'gclient', 8 'gclient',
9 'path', 9 'path',
10 'platform', 10 'platform',
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 }, 161 },
162 'gclient_apply_config': [ 162 'gclient_apply_config': [
163 'v8_bleeding_edge_git', 163 'v8_bleeding_edge_git',
164 'chromium_lkcr', 164 'chromium_lkcr',
165 'show_v8_revision', 165 'show_v8_revision',
166 ], 166 ],
167 'set_component_rev': {'name': 'src/v8', 'rev_str': '%s'}, 167 'set_component_rev': {'name': 'src/v8', 'rev_str': '%s'},
168 }, 168 },
169 }, 169 },
170 }, 170 },
171 'chromium.fyi': {
172 'builders': {
173 'Windows GN': {
174 'chromium_config_kwargs': {
175 'BUILD_CONFIG': 'Release',
176 },
177 },
178 'Windows GN (dbg)': {
179 'chromium_config_kwargs': {
180 'BUILD_CONFIG': 'Debug',
181 },
182 },
183 },
184 },
185 } 171 }
186 172
187 def GenSteps(api): 173 def GenSteps(api):
188 # TODO: crbug.com/358481 . The build_config should probably be a property 174 # TODO: crbug.com/358481 . The build_config should probably be a property
189 # passed in from slaves.cfg, but that doesn't exist today, so we need a 175 # passed in from slaves.cfg, but that doesn't exist today, so we need a
190 # lookup mechanism to map bot name to build_config. 176 # lookup mechanism to map bot name to build_config.
191 mastername = api.properties.get('mastername') 177 mastername = api.properties.get('mastername')
192 buildername = api.properties.get('buildername') 178 buildername = api.properties.get('buildername')
193 master_dict = BUILDERS.get(mastername, {}) 179 master_dict = BUILDERS.get(mastername, {})
194 bot_config = master_dict.get('builders', {}).get(buildername) 180 bot_config = master_dict.get('builders', {}).get(buildername)
(...skipping 25 matching lines...) Expand all
220 if api.tryserver.is_tryserver: 206 if api.tryserver.is_tryserver:
221 api.step.auto_resolve_conflicts = True 207 api.step.auto_resolve_conflicts = True
222 208
223 api.bot_update.ensure_checkout(force=True) 209 api.bot_update.ensure_checkout(force=True)
224 210
225 api.chromium.runhooks() 211 api.chromium.runhooks()
226 212
227 # TODO(scottmg): goma doesn't work on windows GN builds yet. 213 # TODO(scottmg): goma doesn't work on windows GN builds yet.
228 is_windows = 'Windows' in buildername 214 is_windows = 'Windows' in buildername
229 api.chromium.run_gn(use_goma=not is_windows) 215 api.chromium.run_gn(use_goma=not is_windows)
230 if is_windows: 216 # TODO(dpranke): reenable when we have bots again.
231 api.chromium.c.compile_py.compiler = None 217 #if is_windows:
232 api.chromium.c.compile_py.goma_dir = None 218 # api.chromium.c.compile_py.compiler = None
219 # api.chromium.c.compile_py.goma_dir = None
233 220
234 api.chromium.compile(targets=['all']) 221 api.chromium.compile(targets=['all'])
235 222
236 if bot_config.get('should_run_gn_gyp_compare', False): 223 if bot_config.get('should_run_gn_gyp_compare', False):
237 api.chromium.run_gn_compare() 224 api.chromium.run_gn_compare()
238 225
239 # TODO(dpranke): crbug.com/353854. Run gn_unittests and other tests 226 # TODO(dpranke): crbug.com/353854. Run gn_unittests and other tests
240 # when they are also being run as part of the try jobs. 227 # when they are also being run as part of the try jobs.
241 228
242 229
(...skipping 21 matching lines...) Expand all
264 yield test 251 yield test
265 252
266 yield ( 253 yield (
267 api.test('compile_failure') + 254 api.test('compile_failure') +
268 api.platform.name('linux') + 255 api.platform.name('linux') +
269 api.properties.tryserver( 256 api.properties.tryserver(
270 buildername='linux_chromium_gn_rel', 257 buildername='linux_chromium_gn_rel',
271 mastername='tryserver.chromium.linux') + 258 mastername='tryserver.chromium.linux') +
272 api.step_data('compile', retcode=1) 259 api.step_data('compile', retcode=1)
273 ) 260 )
OLDNEW
« no previous file with comments | « masters/master.chromium.fyi/slaves.cfg ('k') | scripts/slave/recipes/chromium_gn.expected/full_chromium_fyi_Windows_GN.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698