Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 7000023: Do inline object filtering (via page flags) before call to RecordWriteStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ia32/full-codegen-ia32.cc
diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc
index b1122a7f99ecac5420442c35443fd049237fb61f..715362be05bad55544e17641ce0299371109eb55 100644
--- a/src/ia32/full-codegen-ia32.cc
+++ b/src/ia32/full-codegen-ia32.cc
@@ -3186,7 +3186,11 @@ void FullCodeGenerator::EmitSwapElements(ZoneList<Expression*>* args) {
NearLabel no_remembered_set;
__ InNewSpace(elements, temp, equal, &no_remembered_set);
- __ HasScanOnScavenge(elements, temp, &no_remembered_set);
+ __ CheckPageFlag(elements,
+ temp,
+ MemoryChunk::SCAN_ON_SCAVENGE,
+ not_zero,
+ &no_remembered_set);
__ mov(object, elements);
// Since we are swapping two objects, the incremental marker is not disturbed,

Powered by Google App Engine
This is Rietveld 408576698