Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 7000023: Do inline object filtering (via page flags) before call to RecordWriteStub. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/gc
Patch Set: Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | src/ia32/macro-assembler-ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/code-stubs-ia32.cc
diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc
index d8b83c572d0ce9a172573c98226f5d35bd3b7c18..088d25fbb71f2bc778cddc639ea4e516c82e889d 100644
--- a/src/ia32/code-stubs-ia32.cc
+++ b/src/ia32/code-stubs-ia32.cc
@@ -5988,24 +5988,15 @@ void RecordWriteStub::Generate(MacroAssembler* masm) {
masm->set_opcode(-2, kTwoByteNopInstruction);
}
- if (FLAG_debug_code) {
- NearLabel ok;
- __ cmp(value_, Operand(address_, 0));
- __ j(equal, &ok);
- __ Abort("Registers did not match in write barrier");
- __ bind(&ok);
- }
-
if (emit_remembered_set_ == EMIT_REMEMBERED_SET) {
NearLabel skip;
- __ HasScanOnScavenge(object_, value_, &skip);
__ RememberedSetHelper(address_, value_, save_fp_regs_mode_);
__ bind(&skip);
}
__ ret(0);
__ bind(&skip_non_incremental_part);
-
+ __ mov(value_, Operand(address_, 0));
GenerateIncremental(masm);
}
@@ -6060,7 +6051,11 @@ void RecordWriteStub::GenerateIncrementalValueIsInNewSpace(
// the scan_on_scavenge flag on the object's page?
if (emit_remembered_set_ == EMIT_REMEMBERED_SET) {
Label scan_on_scavenge;
- __ HasScanOnScavenge(regs_.object(), regs_.scratch0(), &scan_on_scavenge);
+ __ CheckPageFlag(regs_.object(),
+ regs_.scratch0(),
+ MemoryChunk::SCAN_ON_SCAVENGE,
+ not_zero,
+ &scan_on_scavenge);
GenerateIncrementalValueIsInNewSpaceObjectIsInOldSpaceRememberedSet(masm);
__ bind(&scan_on_scavenge);
}
« no previous file with comments | « no previous file | src/ia32/full-codegen-ia32.cc » ('j') | src/ia32/macro-assembler-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698