MacViews: Add a CreateChromeConstrainedWindowViewsClient stub

MacViews: Add a CreateChromeConstrainedWindowViewsClient stub

The MacViews "chrome" compile regressed in r301203

This adds a stub that just returns
scoped_ptr<ConstrainedWindowViewsClient>(nullptr) and fixes some
NativeWindow/NativeView inconsistencies (popup_manager->GetHostView()
returns a view).

The component is compiled on MacViews, since it will eventually be
needed. At link time for `chrome`, everything except the a pure virtual
destructor call will be culled since they are unused, but this approach
keeps component usage consistent with the test targets, which do have
the whole component.

note that components_unittests ConstrainedWindowViewsTest.* all pass on
a MacViews build except for one check against a dialog size
(constrained_window_views_unittest.cc line 142).

BUG=390755, 410499
Committed: https://crrev.com/313354c4fea32e7dc12130621062a1ca402cc03d
Cr-Commit-Position: refs/heads/master@{#302552}

[tapted, 2014-11-03 06:50:30]

tapted@chromium.org changed reviewers:
+ msw@chromium.org

[tapted, 2014-11-03 07:11:42]

Hi Michael, please take a look. I think this is the right approach. Another
approach would be simply to add #ifdefs to ChromeBrowserMainExtraPartsViews, but
this should be more robust.

https://codereview.chromium.org/699553002/diff/1/chrome/browser/ui/views/chro...
File chrome/browser/ui/views/chrome_constrained_window_views_client.cc (right):

https://codereview.chromium.org/699553002/diff/1/chrome/browser/ui/views/chro...
chrome/browser/ui/views/chrome_constrained_window_views_client.cc:31: Browser*
browser = chrome::FindBrowserWithWindow(parent);
note this line only works on aura currently, but it needs to be fixed higher up.
WebModal dialogs are owned by a WebContents, and only the WebContents for the
active tab on Mac have an associated NSWindow. They all have an NSView, but
there's no FindBrowser* for that.

The fix is probably that TODO already at constrained_window_views.cc:154
"TODO(gbillock): Replace this with PopupManager calls". which I think will
remove the need for GetModalDialogHost() altogether. That TODO is probably made
a lot easier by MacViews, and so the circle is complete :)

But that's all for another day..

[tapted, 2014-11-03 07:19:05]

https://codereview.chromium.org/699553002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/chrome_constrained_window_views_client.cc (right):

https://codereview.chromium.org/699553002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/chrome_constrained_window_views_client.cc:31: Browser*
browser = chrome::FindBrowserWithWindow(parent);
note this line only works on aura currently, but it needs to be fixed higher up.
WebModal dialogs are owned by a WebContents, and only the WebContents for the
active tab on Mac have an associated NSWindow. They all have an NSView, but
there's no FindBrowser* for that.

The fix is probably that TODO already at constrained_window_views.cc:154
"TODO(gbillock): Replace this with PopupManager calls". which I think will
remove the need for GetModalDialogHost() altogether. That TODO is probably made
a lot easier by MacViews, and so the circle is complete :)

But that's all for another day..

[msw, 2014-11-03 19:20:33]

lgtm with a nit

https://codereview.chromium.org/699553002/diff/20001/chrome/browser/ui/views/...
File chrome/browser/ui/views/chrome_constrained_window_views_client.cc (right):

https://codereview.chromium.org/699553002/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/chrome_constrained_window_views_client.cc:31: Browser*
browser = chrome::FindBrowserWithWindow(parent);
On 2014/11/03 07:19:04, tapted wrote:
> note this line only works on aura currently, but it needs to be fixed higher
up.
> WebModal dialogs are owned by a WebContents, and only the WebContents for the
> active tab on Mac have an associated NSWindow. They all have an NSView, but
> there's no FindBrowser* for that.
> 
> The fix is probably that TODO already at constrained_window_views.cc:154
> "TODO(gbillock): Replace this with PopupManager calls". which I think will
> remove the need for GetModalDialogHost() altogether. That TODO is probably
made
> a lot easier by MacViews, and so the circle is complete :)
> 
> But that's all for another day..

Acknowledged.

https://codereview.chromium.org/699553002/diff/20001/components/constrained_w...
File components/constrained_window/constrained_window_views_client.h (right):

https://codereview.chromium.org/699553002/diff/20001/components/constrained_w...
components/constrained_window/constrained_window_views_client.h:27: // Returns
the modal window host for the |parent| native window.
nit: update comment: s/native window/native view/?

[tapted, 2014-11-04 00:14:33]

https://codereview.chromium.org/699553002/diff/20001/components/constrained_w...
File components/constrained_window/constrained_window_views_client.h (right):

https://codereview.chromium.org/699553002/diff/20001/components/constrained_w...
components/constrained_window/constrained_window_views_client.h:27: // Returns
the modal window host for the |parent| native window.
On 2014/11/03 19:20:33, msw wrote:
> nit: update comment: s/native window/native view/?

Done.

[tapted, 2014-11-04 00:14:39]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2014-11-04 00:18:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/699553002/40001

[commit-bot: I haz the power, 2014-11-04 02:24:10]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 02:24:34]

Patchset 3 (id:??) landed as
https://crrev.com/313354c4fea32e7dc12130621062a1ca402cc03d
Cr-Commit-Position: refs/heads/master@{#302552}