[Mac] Don't copy text typed into the find bar to the find pasteboard in incognito windows.

[Mac] Don't copy text typed into the find bar to the find pasteboard in incognito windows.

BUG=85306
TEST=See bug

[Bernhard Bauer, 2011-06-08 14:39:51]

please review.

[Robert Sesek, 2011-06-08 14:46:06]

LGTM

http://codereview.chromium.org/6995074/diff/1001/chrome/browser/ui/cocoa/find...
File chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm (right):

http://codereview.chromium.org/6995074/diff/1001/chrome/browser/ui/cocoa/find...
chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm:175: if
(!tab_contents->profile()->IsOffTheRecord()) {
Add a comment that references this bug so it's more clear as to why this is
done.

[rohitrao (ping after 24h), 2011-06-08 15:11:12]

Please wait one minute on this.  I'm trying to dig a previous attempt out of my
email.

[rohitrao (ping after 24h), 2011-06-08 15:17:21]

I wrote this exact CL a year ago, but it turned out to be completely broken.  I
just can't remember why =)  TVL was the one who gave me the test case to try,
but I doubt he remembers either.

http://codereview.chromium.org/661024

It had something to do with the fact that that find "backend" keeps track of the
last find term, but on OS X we always drive the find off of what's in the
pasteboard.  When you start conditionally copying to the pasteboard, the find
backend starts to get out of sync with what's displayed in the findbar, or
something like that.

Try searching for something in incognito, then doing a Cmd-G in a new
non-incognito tab.  Or something like that =)

[Bernhard Bauer, 2011-06-08 15:23:48]

On 2011/06/08 15:17:21, rohitrao wrote:
> I wrote this exact CL a year ago, but it turned out to be completely broken. 
I
> just can't remember why =)  TVL was the one who gave me the test case to try,
> but I doubt he remembers either.
> 
> http://codereview.chromium.org/661024
> 
> It had something to do with the fact that that find "backend" keeps track of
the
> last find term, but on OS X we always drive the find off of what's in the
> pasteboard.  When you start conditionally copying to the pasteboard, the find
> backend starts to get out of sync with what's displayed in the findbar, or
> something like that.
> 
> Try searching for something in incognito, then doing a Cmd-G in a new
> non-incognito tab.  Or something like that =)

Hm, it seems that hitting Cmd-G in an incognito window doesn't use the string
that was typed into the the find bar now. I'll take a look.

[rohitrao (ping after 24h), 2011-06-08 15:30:37]

> Hm, it seems that hitting Cmd-G in an incognito window doesn't use the string
> that was typed into the the find bar now. I'll take a look.

Yes, that sounds somewhat familiar.  When you do a find, the find backend*
caches the search term.  Then, when you press Cmd-G to Find Next, it uses that
cached value to do the search.  When you press Cmd-G, the code never actually
looks at the value in the findbar itself.

On OS X, we integrate the pasteboard by always ignoring the search term (cached
or typed) and replacing it with what's on the pasteboard.  Until now, the cached
value has always been ignored, so it didn't matter if it was wrong.  If we start
conditionally copying to the pasteboard, then we need to start making sure that
the cached search term is always correct.

I'll update my old CL and bug with this test case when I get a chance.