Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 661024: [Mac] Do not copy to the find pasteboard when in Incognito mode....

Created:
10 years, 10 months ago by rohitrao (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
Visibility:
Public.

Description

[Mac] Do not copy to the find pasteboard when in Incognito mode. Typing into the findbar when in Incognito mode does not update the find pasteboard. Cmd-E always updates the find pasteboard, even when in Incognito mode. The Incognito window still responds to pasteboard updates, so typing in a non-Incognito findbar (or pressing Cmd-E in any application) still updates the search text in the Incognito findbar. BUG=32021 TEST=Verify that the above three statements are true.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/cocoa/find_bar_cocoa_controller.mm View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
rohitrao (ping after 24h)
See the CL description for the desired Incognito+FindPBoard behavior. I polled everyone in the cube ...
10 years, 10 months ago (2010-02-24 22:29:02 UTC) #1
rohitrao (ping after 24h)
10 years, 10 months ago (2010-02-24 22:35:31 UTC) #2
Hold up, this is totally broken =)

Powered by Google App Engine
This is Rietveld 408576698