Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 699453005: Get gpudft support working in dm, gm, nanobench and bench_pictures (Closed)

Created:
6 years, 1 month ago by jvanverth1
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Get gpudft support working in dm, gm, nanobench and bench_pictures Adds a new config to test distance field text. Clean up some flags and #defines to read "distance field text", not "distance field fonts" to be consistent with Chromium NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/06ba179838ba4fe187cf290750aeeb4a02a2960b Committed: https://skia.googlesource.com/skia/+/4736e1434ae329e3a737dfd9504c22b3fc13dc72

Patch Set 1 #

Patch Set 2 : Fix alignment #

Patch Set 3 : Fix ANGLE #

Patch Set 4 : More compile fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -48 lines) Patch
M bench/nanobench.cpp View 1 2 5 chunks +22 lines, -15 lines 0 comments Download
M dm/DM.cpp View 1 2 3 1 chunk +10 lines, -9 lines 0 comments Download
M dm/DMGpuGMTask.h View 2 chunks +3 lines, -1 line 0 comments Download
M dm/DMGpuGMTask.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M dm/DMGpuSupport.h View 2 chunks +7 lines, -3 lines 0 comments Download
M gm/gmmain.cpp View 3 chunks +8 lines, -1 line 0 comments Download
M gyp/common_conditions.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_variables.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/SkGpuDevice.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 6 chunks +8 lines, -6 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/PictureRenderer.h View 5 chunks +10 lines, -0 lines 0 comments Download
M tools/PictureRenderer.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tools/PictureRenderingFlags.cpp View 4 chunks +7 lines, -1 line 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
jvanverth1
There's one weirdness here that I didn't address -- SkGpuDevice takes both SkSurfaceProps (which contain ...
6 years, 1 month ago (2014-11-06 20:42:27 UTC) #2
mtklein
lgtm
6 years, 1 month ago (2014-11-06 20:50:23 UTC) #3
bsalomon
On 2014/11/06 20:42:27, jvanverth1 wrote: > There's one weirdness here that I didn't address -- ...
6 years, 1 month ago (2014-11-06 20:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699453005/20001
6 years, 1 month ago (2014-11-06 21:28:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 06ba179838ba4fe187cf290750aeeb4a02a2960b
6 years, 1 month ago (2014-11-06 21:38:57 UTC) #7
jvanverth1
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/707723005/ by jvanverth@google.com. ...
6 years, 1 month ago (2014-11-06 21:51:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699453005/60001
6 years, 1 month ago (2014-11-07 15:03:32 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 15:12:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/4736e1434ae329e3a737dfd9504c22b3fc13dc72

Powered by Google App Engine
This is Rietveld 408576698