Support InputMethodManager#updateCursorAnchorInfo for Android 5.0

content/browser/renderer_host/render_widget_host_view_android.cc

Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index 3a2dc883f4031ea824c2b2088f2d1ecfceae9ecb..8b47a319db12d6008e5e0894dbbb56afa37d54eb 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -1234,11 +1234,28 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(
   if (!content_view_core_)
     return;
 
+  const cc::ViewportSelectionBound& selection_start =
+      frame_metadata.selection_start;
+  const cc::ViewportSelectionBound& selection_end =
+      frame_metadata.selection_start;
   if (selection_controller_) {
-    selection_controller_->OnSelectionBoundsChanged(
-        frame_metadata.selection_start, frame_metadata.selection_end);
+    selection_controller_->OnSelectionBoundsChanged(selection_start,
+                                                    selection_end);
   }
 
+  const bool has_insertion_marker =
+      selection_start.type == cc::SELECTION_BOUND_CENTER &&
+      selection_end.type == cc::SELECTION_BOUND_CENTER &&
+      selection_start.edge_top.x() == selection_start.edge_bottom.x() &&
+      selection_end.edge_top.x() == selection_end.edge_bottom.x() &&
+      selection_start.edge_top.x() == selection_end.edge_bottom.x();

[bcwhite, 2014/11/06 18:57:19]

Is there any chance these floats have tiny differences and thus are not "=="?

[yukawa, 2014/11/07 00:52:47]

Good point.  Basically those conditions are always true when type ==
cc::SELECTION_BOUND_CENTER.  In other words, these conditions are for
"just-in-case".  Maybe we might want to avoid such kind of "just-in-case" code
until we actually need them.  System Chromium WebView is updatable in L and
later so I guess we should focus more on keeping the code simple.  Hence I
deleted those conditions in the patch set #2.  Does it make sense?

[bcwhite, 2014/11/07 01:15:07]

Yes.  If it's not broken, don't fix it.  You could be really paranoid and
average the two values in the calculations below but it's probably not
necessary.  And average might be wrong, too, should they ever differ.

+  const float insertion_marker_x =
+      has_insertion_marker ? selection_start.edge_top.x() : 0.0f;
+  const float insertion_marker_top =
+      has_insertion_marker ? selection_start.edge_top.y() : 0.0f;
+  const float insertion_marker_bottom =
+      has_insertion_marker ? selection_start.edge_bottom.y() : 0.0f;
+
   // All offsets and sizes are in CSS pixels.
   content_view_core_->UpdateFrameInfo(
       frame_metadata.root_scroll_offset,
@@ -1248,7 +1265,11 @@ void RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(
       frame_metadata.root_layer_size,
       frame_metadata.scrollable_viewport_size,
       frame_metadata.location_bar_offset,
-      frame_metadata.location_bar_content_translation);
+      frame_metadata.location_bar_content_translation,
+      has_insertion_marker,
+      insertion_marker_x,
+      insertion_marker_top,
+      insertion_marker_bottom);
 #if defined(VIDEO_HOLE)
   if (host_ && host_->IsRenderView()) {
     RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(