Support InputMethodManager#updateCursorAnchorInfo for Android 5.0

content/browser/renderer_host/render_widget_host_view_android.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_android.h"
 
 #include <android/bitmap.h>
 
 #include "base/android/build_info.h"
 #include "base/basictypes.h"
@@ skipping 1216 matching lines @@
   // web design, so text will be legible without zooming). Also disable
   // double tap and pinch for pages that prevent zooming in or out.
   bool has_mobile_viewport = HasMobileViewport(frame_metadata);
   bool has_fixed_page_scale = HasFixedPageScale(frame_metadata);
   gesture_provider_.SetDoubleTapSupportForPageEnabled(
       !has_fixed_page_scale && !has_mobile_viewport);
 
   if (!content_view_core_)
     return;
 
+  const cc::ViewportSelectionBound& selection_start =
+      frame_metadata.selection_start;
+  const cc::ViewportSelectionBound& selection_end =
+      frame_metadata.selection_start;
   if (selection_controller_) {
-    selection_controller_->OnSelectionBoundsChanged(
-        frame_metadata.selection_start, frame_metadata.selection_end);
+    selection_controller_->OnSelectionBoundsChanged(selection_start,
+                                                    selection_end);
   }
 
+  const bool has_insertion_marker =
+      selection_start.type == cc::SELECTION_BOUND_CENTER &&
+      selection_end.type == cc::SELECTION_BOUND_CENTER &&
+      selection_start.edge_top.x() == selection_start.edge_bottom.x() &&
+      selection_end.edge_top.x() == selection_end.edge_bottom.x() &&
+      selection_start.edge_top.x() == selection_end.edge_bottom.x();

[bcwhite, 2014/11/06 18:57:19]

Is there any chance these floats have tiny differences and thus are not "=="?

[yukawa, 2014/11/07 00:52:47]

Good point.  Basically those conditions are always true when type ==
cc::SELECTION_BOUND_CENTER.  In other words, these conditions are for
"just-in-case".  Maybe we might want to avoid such kind of "just-in-case" code
until we actually need them.  System Chromium WebView is updatable in L and
later so I guess we should focus more on keeping the code simple.  Hence I
deleted those conditions in the patch set #2.  Does it make sense?

[bcwhite, 2014/11/07 01:15:07]

Yes.  If it's not broken, don't fix it.  You could be really paranoid and
average the two values in the calculations below but it's probably not
necessary.  And average might be wrong, too, should they ever differ.

+  const float insertion_marker_x =
+      has_insertion_marker ? selection_start.edge_top.x() : 0.0f;
+  const float insertion_marker_top =
+      has_insertion_marker ? selection_start.edge_top.y() : 0.0f;
+  const float insertion_marker_bottom =
+      has_insertion_marker ? selection_start.edge_bottom.y() : 0.0f;
+
   // All offsets and sizes are in CSS pixels.
   content_view_core_->UpdateFrameInfo(
       frame_metadata.root_scroll_offset,
       frame_metadata.page_scale_factor,
       gfx::Vector2dF(frame_metadata.min_page_scale_factor,
                      frame_metadata.max_page_scale_factor),
       frame_metadata.root_layer_size,
       frame_metadata.scrollable_viewport_size,
       frame_metadata.location_bar_offset,
-      frame_metadata.location_bar_content_translation);
+      frame_metadata.location_bar_content_translation,
+      has_insertion_marker,
+      insertion_marker_x,
+      insertion_marker_top,
+      insertion_marker_bottom);
 #if defined(VIDEO_HOLE)
   if (host_ && host_->IsRenderView()) {
     RenderViewHostImpl* rvhi = static_cast<RenderViewHostImpl*>(
         RenderViewHost::From(host_));
     rvhi->media_web_contents_observer()->OnFrameInfoUpdated();
   }
 #endif  // defined(VIDEO_HOLE)
 }
 
 void RenderWidgetHostViewAndroid::AcceleratedSurfaceInitialized(int route_id) {
@@ skipping 549 matching lines @@
   results->orientationAngle = display.RotationAsDegree();
   results->orientationType =
       RenderWidgetHostViewBase::GetOrientationTypeForMobile(display);
   gfx::DeviceDisplayInfo info;
   results->depth = info.GetBitsPerPixel();
   results->depthPerComponent = info.GetBitsPerComponent();
   results->isMonochrome = (results->depthPerComponent == 0);
 }
 
 } // namespace content