Issue 699203004: [telemetry] Fix typo in login error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 699203004: [telemetry] Fix typo in login error handling. (Closed)

Created:
6 years, 1 month ago by dtu

Modified:
6 years, 1 month ago

Reviewers:
tonyg

CC:
chromium-reviews, telemetry+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

[telemetry] Fix typo in login error handling. BUG=None. TEST=None. Committed: https://crrev.com/25e2aae969344a3ef7918cb9b2a5a7ef35457649 Cr-Commit-Position: refs/heads/master@{#302732}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

dtu

This is a kind of error that should be caught by static analysis. I think ...

6 years, 1 month ago (2014-11-04 21:39:15 UTC) #2

tonyg

lgtm I believe Ned had the same fix awaiting your review. We'll see which one ...

6 years, 1 month ago (2014-11-05 00:29:41 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/699203004/1

6 years, 1 month ago (2014-11-05 00:30:47 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-05 01:29:45 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/25e2aae969344a3ef7918cb9b2a5a7ef35457649
Cr-Commit-Position: refs/heads/master@{#302732}