tools/telemetry/telemetry/page/page_runner.py - Issue 699203004: [telemetry] Fix typo in login error handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 699203004: [telemetry] Fix typo in login error handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/page/page_runner.py

diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py

index f9e02e81d7107464e46b987d94679d837cb6ca9e..bb4dec5c5ff983ff0cac5daf27937cc79a4b58f2 100644

--- a/tools/telemetry/telemetry/page/page_runner.py

+++ b/tools/telemetry/telemetry/page/page_runner.py

@@ -140,7 +140,8 @@ class _RunState(object):

if self._current_page.credentials:

if not self.browser.credentials.LoginNeeded(

self._current_tab, self._current_page.credentials):

- raise page_test.Failure('Login as ' + self.page.credentials + ' failed')

+ raise page_test.Failure(

+ 'Login as ' + self._current_page.credentials + ' failed')

self._did_login_for_current_page = True

if self._test.clear_cache_before_each_run:

« no previous file with comments | « no previous file | no next file » | no next file with comments »